Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JVM] Add retry logic for JVM #740

Merged
merged 3 commits into from
Dec 4, 2024
Merged

[JVM] Add retry logic for JVM #740

merged 3 commits into from
Dec 4, 2024

Conversation

arthurscchan
Copy link
Collaborator

This PR add back the retry logic for JVM when the first generated harness is failed to build.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@arthurscchan
Copy link
Collaborator Author

/gcbrun exp -n ascc-jvm-pr-740-1 -m vertex_ai_gemini-1-5 -i -b jvm-small

@arthurscchan
Copy link
Collaborator Author

/gcbrun exp -n ascc-jvm-pr-740-2 -m vertex_ai_gemini-1-5 -i -b test-to-harness-jvm-small

@arthurscchan
Copy link
Collaborator Author

/gcbrun exp -n ascc-jvm-pr-740-3 -m vertex_ai_gemini-1-5 -i -b comparison

@DavidKorczynski
Copy link
Collaborator

@arthurscchan the java experiments didn't seem to work -- can you double check?

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@arthurscchan
Copy link
Collaborator Author

/gcbrun exp -n ascc-jvm-pr-740-4 -m vertex_ai_gemini-1-5 -i -b test-to-harness-jvm-small

@DavidKorczynski
Copy link
Collaborator

@arthurscchan
Copy link
Collaborator Author

/gcbrun exp -n ascc-jvm-pr-740-5 -m vertex_ai_gemini-1-5 -i -b jvm-small

@DavidKorczynski
Copy link
Collaborator

both java experiments are looking good

@DavidKorczynski
Copy link
Collaborator

/gcbrun exp -n dgk123 -m vertex_ai_gemini-1-5 -i -b comparison

@DavidKorczynski
Copy link
Collaborator

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java builds are looking real nice.

@DavidKorczynski DavidKorczynski merged commit 66fff58 into main Dec 4, 2024
5 checks passed
@DavidKorczynski DavidKorczynski deleted the add-retry-jvm branch December 4, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants