Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inih] fix using official repo #10752

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[inih] fix using official repo #10752

merged 1 commit into from
Jul 27, 2023

Conversation

0x34d
Copy link
Contributor

@0x34d 0x34d commented Jul 27, 2023 •
edited
Loading

@alan32liu you missed it.

@0x34d
[inih] fix
3de3dd3 
Signed-off-by: Arjun Singh <ajsinghyadav00@gmail.com>
@github-actions
Copy link

0x34d is either the primary contact or is in the CCs list of projects/inih.
0x34d has previously contributed to projects/inih. The previous PR was #10707

This was referenced Jul 27, 2023
Closed
Merged
jonathanmetzman
jonathanmetzman approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit d01dc89 into google:master Jul 27, 2023
@DonggeLiu
Copy link
Contributor

@0x34d Shall we remove the inih directory here, given the maintainer has removed the support from the repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x34d @DonggeLiu @jonathanmetzman