infra: downgrade rust #11681
Merged
infra: downgrade rust #11681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Korczynski <david@adalogics.com>
|
I can confirm that Tokio (from #11626) builds correctly with coverage and I'm able to do a full run (1) build fuzzers; (2) run fuzzers; (3) build with coverage; (4) generate HTML report of Tokio. |
|
Am able to generate full runs (fuzz + coverage) for:
which are a subset of the projects mentioned in #11626 -- I didn't test all the projects mentioned in the PR, but I didn't run into any projects that failed coverage builds. |
Signed-off-by: David Korczynski <david@adalogics.com>
|
/gcbrun trial_build.py all --fuzzing-engines libfuzzer |
|
/gcbrun trial_build.py rust --engine libfuzzer --sanitizer coverage |
|
/gcbrun trial_build.py rust --fuzzing-engines libfuzzer --sanitizers coverage address |
This was referenced Apr 3, 2024
jonathanmetzman
pushed a commit
that referenced
this pull request
Apr 5, 2024
The rust-lang/rust#110475 issue referenced is no longer a problem since the `geo` crate has been updated in SurrealDB. However, the change in default Rust version in the image builder implemented in #11681 breaks fuzzing due to SurrealDB now requiring Rust 1.77 after surrealdb/surrealdb#3591, leading to a bump in the MSRV in surrealdb/surrealdb#3778. I have replaced the obsolete `--cfg uuid_unstable` for the generic `--cfg surrealdb_unstable`, which will allow fuzzing any features still deemed unstable in SurrealDB including the new experimental parser.
alexcrichton
added a commit
to alexcrichton/oss-fuzz
that referenced
this pull request
Jun 17, 2024
This commit updates the default version of Rust installed for fuzzing. In google#11626 it was found that at the time Rust's upgraded version of LLVM didn't play well with the LLVM used on OSS-Fuzz, but since then Rust was temporarily pinned in google#11681 to an older nightly. It looks like though that in google#11714 the LLVM version was upgraded to 18 so this updates Rust to today's nightly which is using LLVM 18.1.7. Discussion in google#11626 seems to point in the direction of keeping Rust pinned rather than going back to using `nightly` which updates each day. The motivation for this commit is that the Wasmtime project is seeing [build failures][log] for using APIs stabilized in Rust 1.77.0. The older nightly version used on OSS-Fuzz doesn't have access to these APIs, so this update should help resolve Wasmtime's build failure. [log]: https://oss-fuzz-build-logs.storage.googleapis.com/log-cc290775-8669-4cba-8370-60d5a56a9de8.txt
alexcrichton
added a commit
to alexcrichton/oss-fuzz
that referenced
this pull request
Jun 17, 2024
This commit updates the default version of Rust installed for fuzzing. In google#11626 it was found that at the time Rust's upgraded version of LLVM didn't play well with the LLVM used on OSS-Fuzz, but since then Rust was temporarily pinned in google#11681 to an older nightly. It looks like though that in google#11714 the LLVM version was upgraded to 18 so this updates Rust to today's nightly which is using LLVM 18.1.7. Discussion in google#11626 seems to point in the direction of keeping Rust pinned rather than going back to using `nightly` which updates each day. The motivation for this commit is that the Wasmtime project is seeing [build failures][log] for using APIs stabilized in Rust 1.77.0. The older nightly version used on OSS-Fuzz doesn't have access to these APIs, so this update should help resolve Wasmtime's build failure. [log]: https://oss-fuzz-build-logs.storage.googleapis.com/log-cc290775-8669-4cba-8370-60d5a56a9de8.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrades Rust to nightly at 28th Dec 2023. The version that is build is: