Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust coverage: fix binary ids padding #6551

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

catenacyber
Copy link
Contributor

Following #6517

Since then, the new LLVM 14 commit b9f547e8e51182d32f1912f97a3e53f4899ea6be https://reviews.llvm.org/D110365
added a new change (adding a padding and erroring if a field size is not a multiple of sizeof(uint64))

cc @jonathanmetzman

@catenacyber
Copy link
Contributor Author

Tested on flate2-rs

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman
Copy link
Contributor

@catenacyber Could you convert this to python please?

@jonathanmetzman jonathanmetzman merged commit 657d3dd into google:master Oct 4, 2021
@catenacyber
Copy link
Contributor Author

Thanks Johnathan.
I did not forget about python, but I want to check that rust goes green first

@catenacyber
Copy link
Contributor Author

Most rust projects seem to have coverage fixed

Some rust projects have their fuzzing build broken :
libra, oak, prost, rust-regex, suricata

Some projects have their fuzzing build ok but their coverage build broken :
linkerd2-proxy (same problem as rustls), opensk (relative path instead of absolute for some rust sources), rustls (problem of path of C files compiled by rust)
So these are other problems, likely missing remap-path-prefix

Not yet rebuilt today :
servo, wastime

So, next is to rewrite in python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants