Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine installed is too generic and might be conflict with other files with the same name #124

Closed
another-rex opened this issue Jan 9, 2023 · 0 comments · Fixed by #94
Closed
Labels
enhancement New feature or request

Comments

@another-rex
Copy link
Collaborator

See #107 (comment)

A potential solution suggested there is:

G-Rath:
I wonder if this should be handled similar to git, sboms and csvs in osv-detector (which are a parser located in lockfile, but are never assumed when scanning directories - you have to explicitly say "this is a CSV I want you to check") - because /lib/apk/db/installed is very specific, so you're only ever going to get it checked if you run the scanner from anywhere along that path with -r anyway

So what if instead it had a dedicated flag, like --check-apk-installed?

#94 could then be used as a way of telling the scanner to treat arbitrary files as installed, but the scanner would never automatically assume a file called installed should be parsed as-such

@G-Rath G-Rath mentioned this issue Jan 10, 2023
@another-rex another-rex added the enhancement New feature or request label Jan 10, 2023
cmaritan pushed a commit to cmaritan/osv-scanner that referenced this issue Feb 12, 2023
hayleycd pushed a commit that referenced this issue Mar 9, 2023
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this issue May 2, 2023
julieqiu pushed a commit to julieqiu/osv-scanner that referenced this issue May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant