Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the latest version of golangci-lint #1185

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented Aug 16, 2024

golangci-lint just released v1.60.1 recently.

This PR updates the version of golangci-lint to its latest version. This should unblock the golangci-lint failures.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (0ecee7c) to head (03488b1).

Files Patch % Lines
cmd/osv-scanner/fix/noninteractive.go 0.00% 2 Missing ⚠️
pkg/osvscanner/osvscanner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
- Coverage   65.79%   65.77%   -0.03%     
==========================================
  Files         165      165              
  Lines       13915    13915              
==========================================
- Hits         9155     9152       -3     
- Misses       4257     4259       +2     
- Partials      503      504       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq changed the title Use the latest version of golangci-lint chore: use the latest version of golangci-lint Aug 19, 2024
@cuixq cuixq marked this pull request as ready for review August 19, 2024 00:15
Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xueqin!

@cuixq cuixq merged commit aedd49a into google:main Aug 19, 2024
13 checks passed
@cuixq cuixq deleted the lint branch August 19, 2024 00:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants