Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace Debian package name with its source name #1422

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Dec 4, 2024

The current v2 container scanning doesn't report any Debian-related vulnerabilities. The reason is that the extractor takes the package name and package version to match against OSV records. But OSV records store records with the source name. Debian packages may have a different source name than their package name (also source version). For example:
image

The new change will convert the given package information to its corresponding source information for matching, if the source information is specified.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (3f1cc5c) to head (e2f40cd).

Files with missing lines Patch % Lines
internal/image/scan.go 53.33% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1422   +/-   ##
=======================================
  Coverage   69.76%   69.76%           
=======================================
  Files         186      186           
  Lines       18562    18575   +13     
=======================================
+ Hits        12949    12959   +10     
- Misses       4916     4917    +1     
- Partials      697      699    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you make an issue TODO to make debian container scanning tests to catch this in the future?

@hogo6002 hogo6002 merged commit ee0945a into google:v2 Dec 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants