Make grouper public #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
approved these changes
Dec 12, 2022
pkg/models/groups.go
Outdated
| @@ -0,0 +1,21 @@ | |||
| package models | |||
|
|
|||
| type IDAliases struct { | |||
There was a problem hiding this comment.
I think this would belong better in the public grouper package instead of the models one, since it's very specific to that use case. Could we move it there instead?
There was a problem hiding this comment.
Can do, but this will cause some issues with cyclic imports, so have to change ToIDAliases from a receiver function to just a normal function.
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
* Make grouper public * Move types from model to grouper * Add some comments about config loading
julieqiu
pushed a commit
to julieqiu/osv-scanner
that referenced
this pull request
May 2, 2023
* Make grouper public * Move types from model to grouper * Add some comments about config loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouper now only takes in what's needed, and is public. By limiting the type that grouper takes in it allows much easier usage externally.