Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a switch for using cached local db in test to improve speed #826

Conversation

billielynch
Copy link
Contributor

@billielynch billielynch commented Feb 27, 2024

regarding : #741

As discussed with google team, moving to using cached local db when not running acceptance tests.

Copy link

google-cla bot commented Feb 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

cmd/osv-scanner/main_test.go Outdated Show resolved Hide resolved
cmd/osv-scanner/main_test.go Outdated Show resolved Hide resolved
cmd/osv-scanner/main_test.go Outdated Show resolved Hide resolved
cmd/osv-scanner/main_test.go Outdated Show resolved Hide resolved
@billielynch billielynch force-pushed the using-cached-data-when-not-test-acceptance-local-db branch from 04860fe to b8b5df7 Compare February 27, 2024 23:58
cmd/osv-scanner/main_test.go Show resolved Hide resolved
internal/testutility/utility.go Outdated Show resolved Hide resolved
internal/local/check.go Show resolved Hide resolved
cmd/osv-scanner/main_test.go Outdated Show resolved Hide resolved
billielynch and others added 2 commits February 28, 2024 13:32
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
@billielynch billielynch changed the title Added a switch for using cached local db Added a switch for using cached local db in test to improve speed Feb 28, 2024
Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome stuff!

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.76%. Comparing base (aa771d2) to head (f33a77d).

Files Patch % Lines
internal/testutility/utility.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   59.78%   59.76%   -0.02%     
==========================================
  Files         136      136              
  Lines       11266    11268       +2     
==========================================
- Hits         6735     6734       -1     
- Misses       4102     4104       +2     
- Partials      429      430       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@another-rex another-rex merged commit c78b38b into google:main Feb 28, 2024
11 checks passed
@G-Rath G-Rath deleted the using-cached-data-when-not-test-acceptance-local-db branch March 4, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants