-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Updates: support parents and dependency imports #890
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 63.58% 63.65% +0.07%
==========================================
Files 146 146
Lines 11922 11940 +18
==========================================
+ Hits 7581 7601 +20
+ Misses 3875 3873 -2
Partials 466 466 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but Maven makes my head hurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some minor comments.
This PR adds support for parents and dependency imports: - fetching and parsing upstream pom.xml files - then merging the data into Maven project - add `RequirementsFromOtherPOMs` to system-specific data to store requirements that we don't have access Some of the Maven code should be provided by `deps.dev/util/maven` and `deps.dev/util/resolve` soon...
This PR adds support for parents and dependency imports:
RequirementsFromOtherPOMs
to system-specific data to store requirements that we don't have accessSome of the Maven code should be provided by
deps.dev/util/maven
anddeps.dev/util/resolve
soon...