Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign source aliases if no alias group is defined #2376

Closed
wants to merge 1 commit into from

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Jul 9, 2024

Some vulnerabilities may lack listed aliases, even if their source data contains them. This occurs when an alias_group exceeds a maximum number of aliases, causing this group to be not added. For example: https://osv.dev/vulnerability/GO-2024-2947

In such cases, assign the original source aliases to the aliases field to match with the source info.

Fixes: #2374

@hogo6002
Copy link
Contributor Author

hogo6002 commented Jul 9, 2024

This can also cause issues where a vulnerability lists different aliases with its alias. Also, the raw aliases may sometimes exceed the maximum number of vulnerabilities allowed. Not sure if we really want to implement this. @michaelkedar

@michaelkedar
Copy link
Member

Yeah, my main issue with doing this is that there's no indication when we do fall back to the raw aliases and, when we do, the returned alias lists become no longer symmetric. So it still can be confusing to consumers...

@hogo6002
Copy link
Contributor Author

hogo6002 commented Aug 8, 2024

This seems not the right approach, close the PR for now.

@hogo6002 hogo6002 closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always return the upstream aliases when no alias groups are generated
2 participants