Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip exporting data into subdirectories #2707

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Oct 8, 2024

Linux distributions have a large number of releases and products. Exporting each release into a subdirectory wastes a lot of memory and reduces exporter performance. Skipping the exporting of these subdirectories and keeping one directory for each ecosystem will improve exporter performance.

This PR will be merged after the weekly release, and performance will be tested on the test instance. If all looks good, an announcement email will be sent before moving this into production.

@hogo6002 hogo6002 requested a review from another-rex October 8, 2024 05:05
Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you also update the documentation of our exports?

@hogo6002 hogo6002 marked this pull request as ready for review October 8, 2024 06:00
@hogo6002 hogo6002 requested a review from oliverchang October 8, 2024 06:01
@hogo6002
Copy link
Contributor Author

hogo6002 commented Oct 8, 2024

LGTM, can you also update the documentation of our exports?

I will test the performance on a test instance first and update it in a follow-up PR after verifying the results.

@hogo6002 hogo6002 merged commit fe8987d into google:master Oct 8, 2024
12 checks passed
hogo6002 added a commit that referenced this pull request Oct 9, 2024
#2707 removed subdirectories from
both the ecosystem export functionality and the `ecosystem.txt` list. To
ensure a smooth transition for users, keep the `ecosystem.txt` file
unchanged for now and then announce this change.

TODO:
- Announce the removal of subdirectories to users
- Remove all ecosystem releases from `ecosystem.txt`
- Update exporter doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants