No "install" target #1
Comments
nealcardwell
added a commit
that referenced
this issue
Aug 21, 2022
…sable
With loose segementation (on by default), and a script line like:
+0 > . 3001:6001(3000) ack 1
...you could get a mystifying error message referring to a mysterious expected
sequence number of 12001 that the script did not really expect, without any
dumping of the expected or actual skbs to explain why:
bbr-fr-startup-sacks-grow-inflight.pkt:45: error handling packet:
live packet field tcp_seq: expected: 12001 (0x2ee1) vs actual: 3001 (0xbb9)
Now with this commit the error message dumps the full sequence of sniffed skbs,
along with the expected skb:
bbr-fr-startup-sacks-grow-inflight.pkt:45: error handling packet:
live packet field tcp_seq: expected: 12001 (0x2ee1) vs actual: 3001 (0xbb9)
script packet: 0.042528 . 3001:6001(3000) ack 1
actual #0 packet: 0.042468 . 10001:12001(2000) ack 1 win 256
actual #1 packet: 0.043177 . 3001:4001(1000) ack 1 win 256
With this info, the reader can see why a sequence of 12001 was expected by
packetdrill.
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Change-Id: I932ce693a674efd320588fb6ab8b0aa67a961111
nealcardwell
pushed a commit
that referenced
this issue
Nov 15, 2022
…ing cmsg from expressions
when packetdrill builds a cmsg parsed from the script, it handles
'ee_origin', 'ee_type' and 'ee_code' as 32-bit numbers. These members of
'struct sock_extended_err' are 8-bit wide: because of this, TCP tests
belonging to 'timestamping' and 'zerocopy' categories systematically fail
on big endian architectures (such as s390x). For example, the value of
'ee_origin' is written in 'ee_pad':
(gdb) set args -D TFO_COOKIE=de4f234f0f433a55 -D CMSG_LEVEL_IP=SOL_IP -D CMSG_TYPE_RECVERR=IP_RECVERR basic.pkt
(gdb) r
[...]
24: system call: recvmsg
24: invoke call: recvmsg
waiting until 1668090937472983 -- now is 1668090937472985
expected: 0.000 actual: 0.000 (secs)
Thread 1 "packetdrill" hit Breakpoint 2, new_extended_err (expr=0x111e7a0, ee=0x1124d80, error=0x3ffffff9730)
at run_system_call.c:500
500 if (get_s32(expr->ee_errno, (s32 *)&ee->ee_errno, error))
(gdb) n
502 if (get_s32(expr->ee_origin, (s32 *)&ee->ee_origin, error))
(gdb) n
504 if (get_s32(expr->ee_type, (s32 *)&ee->ee_type, error))
(gdb) p *ee
$46 = {ee_errno = 0, ee_origin = 0 '\000', ee_type = 0 '\000', ee_code = 0 '\000', ee_pad = 5 '\005', ee_info = 0,
ee_data = 0}
(gdb) up
#1 0x000000000101d892 in cmsg_new (expr=0x111f740, msg=0x1124c60, error=0x3ffffff9730) at run_system_call.c:617
617 if (new_extended_err(ee_expr,
(gdb) p *(struct sock_extended_err *)data
$47 = {ee_errno = 0, ee_origin = 0 '\000', ee_type = 0 '\000', ee_code = 0 '\000', ee_pad = 5 '\005', ee_info = 0,
ee_data = 0}
(gdb)
fix it by providing a correct integer size for 'ee_origin', 'ee_type' and 'ee_code'.
Reported-by: Xiumei Mu <xmu@redhat.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original issue reported on code.google.com by
a...@netbsd.orgon 28 Jul 2014 at 11:21The text was updated successfully, but these errors were encountered: