-
Notifications
You must be signed in to change notification settings - Fork 77
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pw_log: Explicitly pass verbosity to PW_LOG
Updates the PW_LOG contract to ensure that PW_LOG's default implementation does not rely on any global preprocessor defines, instead it ensures that all arguments are explicitly passed. This is done by passing the verbosity explicitly as an argument by selecting them in the PW_LOG_* macros instead and updating the PW_LOG_ENABLE_IF to also take in verbosity. Lastly PW_LOG_ENABLE_IF_DEFAULT is removed and PW_LOG_ENABLE_IF is changed to be a module configuration option, meaning that there should be a single definition for a toolchain (this is not permitted to vary between compile units). Change-Id: Idef3483e1aa173295f85b18f4971b2891abb9b25 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/239035 Reviewed-by: Wyatt Hepler <hepler@google.com> Reviewed-by: Ben Lawson <benlawson@google.com> Reviewed-by: Keir Mierle <keir@google.com> Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
- Loading branch information
Showing
11 changed files
with
154 additions
and
119 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.