Skip to content

Commit

Permalink
pw_bluetooth_proxy: Increase H4 buffer size
Browse files Browse the repository at this point in the history
Fixed: 379134135
Change-Id: Ifa9ed8ef8f6c92d89326a7826aa8d3f550993ede
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/246499
Reviewed-by: Alan Rosenthal <alanrosenthal@google.com>
Commit-Queue: Ali Saeed <saeedali@google.com>
Reviewed-by: David Rees <drees@google.com>
Docs-Not-Needed: Ali Saeed <saeedali@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
  • Loading branch information
acsaeed authored and CQ Bot Account committed Nov 16, 2024
1 parent 53d5391 commit a88df25
Showing 1 changed file with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,11 @@ class H4Storage {
// TODO: https://pwbug.dev/353734827 - Allow container to specify constants.
// To pass the unit tests, kNumH4Buffs >= L2capCoc::QueueCapacity().
static constexpr size_t kNumH4Buffs = 10;
// Default of 14 bytes is the size of an H4 packet containing an ACL data
// packet with an ATT Notify PDU for a 2-byte characteristic.
//

// Max LE ACL payload (251 bytes) + ACL header (4 bytes) + H4 type (1 byte).
// TODO: https://pwbug.dev/369849508 - Support variable size buffers with
// an allocator & replace this constant with total memory pool size.
// TODO: saeedali@ - Increase size to 256 bytes: max LE ACL payload size (251
// bytes) + ACL header (4 bytes) + H4 type (1 byte).
static constexpr uint16_t kH4BuffSize = 20;
static constexpr uint16_t kH4BuffSize = 256;

// Returns an initializer list for `h4_buff_occupied_` with each buffer
// address in `h4_buffs_` mapped to false.
Expand Down

0 comments on commit a88df25

Please sign in to comment.