Skip to content

Commit

Permalink
pw_minimal_cpp_stdlib: Disable targets in Bazel build
Browse files Browse the repository at this point in the history
pw_minimal_cpp_stdlib cannot currently build in Bazel, so mark the
offending targets as manual.

Bug: 244743459
Change-Id: I31e9bb94829df88200552c84aa621f223fbb984a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/117298
Commit-Queue: Wyatt Hepler <hepler@google.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
  • Loading branch information
255 authored and CQ Bot Account committed Nov 4, 2022
1 parent 47167b9 commit ff9a876
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions pw_minimal_cpp_stdlib/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,16 @@ pw_cc_library(
],
copts = ["-nostdinc++"],
includes = ["public"],
deps = [
"//pw_polyfill:standard_library",
],
)

pw_cc_library(
name = "minimal_cpp_stdlib_isolated_test",
srcs = ["isolated_test.cc"],
copts = ["-nostdinc++"],
tags = ["manual"], # TODO(b/257529911): Fix build failures.
deps = [
":pw_minimal_cpp_stdlib",
"//pw_preprocessor",
Expand All @@ -81,6 +85,7 @@ pw_cc_test(
srcs = [
"test.cc",
],
tags = ["manual"], # TODO(b/257529911): Fix build failures.
deps = [
":minimal_cpp_stdlib_isolated_test",
"//pw_unit_test",
Expand Down
5 changes: 4 additions & 1 deletion pw_polyfill/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ pw_cc_library(
"standard_library_public/pw_polyfill/standard_library/namespace.h",
],
includes = ["standard_library_public"],
visibility = ["//pw_span:__pkg__"],
visibility = [
"//pw_minimal_cpp_stdlib:__pkg__",
"//pw_span:__pkg__",
],
)

pw_cc_test(
Expand Down
1 change: 0 additions & 1 deletion pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ def cmake_gcc(ctx: PresubmitContext):
'-//pw_log:log_proto_py_pb2_genproto',
'-//pw_log_string/...:all',
'-//pw_metric/...:all',
'-//pw_minimal_cpp_stdlib/...:all',
'-//pw_persistent_ram/...:all',
'-//pw_snapshot/py/...:all',
'-//pw_snapshot:metadata_proto_py_pb2',
Expand Down

0 comments on commit ff9a876

Please sign in to comment.