Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix miss makezero bug #867

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

alingse
Copy link
Contributor

@alingse alingse commented May 26, 2024

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9241873083/job/25423942721

====================================================================================================
append to slice `nodes` with non-zero initialized length at https://github.com/google/pprof/blob/main/internal/graph/graph.go#L44[9](https://github.com/alingse/go-linter-runner/actions/runs/9241873083/job/25423942721#step:4:10):11
====================================================================================================

Signed-off-by: alingse <alingse@foxmail.com>
Copy link

google-cla bot commented May 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.98%. Comparing base (0ed6a68) to head (a699076).
Report is 24 commits behind head on main.

Files Patch % Lines
internal/graph/graph.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   66.86%   66.98%   +0.11%     
==========================================
  Files          44       44              
  Lines        9824     9793      -31     
==========================================
- Hits         6569     6560       -9     
+ Misses       2794     2780      -14     
+ Partials      461      453       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aalexand aalexand merged commit 186aa03 into google:main May 28, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants