Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report missing file name as "", not "." #899

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Report missing file name as "", not "." #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/report/shortnames.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ var (
// fileNameSuffixes returns a non-empty sequence of shortened file names
// (in decreasing preference) that can be used to represent name.
func fileNameSuffixes(name string) []string {
if name == "" {
// Avoid returning "." when symbol info is missing
return []string{""}
}
return allSuffixes(filepath.ToSlash(filepath.Clean(name)), fileSepRE)
}

Expand Down
2 changes: 1 addition & 1 deletion internal/report/shortnames_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestFileNameSuffixes(t *testing.T) {
}

for _, c := range []testCase{
test("empty", "", "."),
test("empty", "", ""),
test("simple", "foo", "foo"),
test("manypaths", "a/b/c", "a/b/c", "b/c", "c"),
test("leading", "/a/b", "/a/b", "a/b", "b"),
Expand Down
Loading