Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared consts for bool.fromEnvironment expressions #772

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

devoncarew
Copy link
Collaborator

This improves the readability of the generated code (see #771 for context).

  • use shared consts to reduce the number of repeated bool.fromEnvironment() expressions (all the bool.fromEnvironment() expressions are gathered up while generated the file and written as consts at the end of the file)
  • turn on a few additional lints
  • update the changelog

Done as three commits for easier review (the dart code changes, regenerating the lib/src/generated files, and regenerating the test goldens). cc @osa1

Copy link
Member

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but added some inline comments and questions.

protoc_plugin/lib/indenting_writer.dart Outdated Show resolved Hide resolved
protoc_plugin/lib/indenting_writer.dart Outdated Show resolved Hide resolved
protoc_plugin/lib/indenting_writer.dart Show resolved Hide resolved
Copy link
Collaborator Author

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated based on review comments -

protoc_plugin/lib/indenting_writer.dart Outdated Show resolved Hide resolved
protoc_plugin/lib/indenting_writer.dart Show resolved Hide resolved
protoc_plugin/lib/indenting_writer.dart Show resolved Hide resolved
protoc_plugin/lib/indenting_writer.dart Outdated Show resolved Hide resolved
@osa1 osa1 merged commit ae90e53 into google:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants