-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #229, #293: Modify parser.py to re-insert quotes correctly #307
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thank you for the PR! You mentioned in our discussion on #229 that you had some test cases. Could you add those to this PR? |
Hello @dbieber! Really sorry for the super-long hiatus. I've added relevant tests (some of which we'd discussed earlier), feel free to suggest additions/modifications to them. |
Hello again. Thanks for adding the tests! |
Passes:
parser_test.py
parser_fuzz_test.py (?)
main_test.py
We are not Python programmers primarily, so do let us know if there are fragments of code that can be rewritten in Python to make it more readable. Other than that, this code conforms faithfully to the flowchart we sent over earlier.