Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: watcher for automerge #435

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ci: watcher for automerge #435

wants to merge 7 commits into from

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Feb 2, 2023

As discussed in #428 (comment) adding a closure job would allow enabling automerge without need of updating branch protection checks when new Python version is added

@Borda
Copy link
Contributor Author

Borda commented Feb 2, 2023

now we could set these two as required checks:
image
cc: @hugovk

@hugovk
Copy link
Contributor

hugovk commented Feb 2, 2023

image

👍

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Borda
Copy link
Contributor Author

Borda commented Feb 7, 2023

@dbieber any idea what is happening with the @CopyBara? as there are no details shared... 🤔

@dbieber
Copy link
Member

dbieber commented Feb 7, 2023

Copybara is the tool we use to sync the google internal copy of the repo with the github copy. The error could be from them getting out of sync; I'll have to look into that. You can ignore that check in the mean time.

@Borda
Copy link
Contributor Author

Borda commented Feb 20, 2023

@dbieber how is it going? 🐿️

@Borda
Copy link
Contributor Author

Borda commented Mar 7, 2023

@dbieber can I help with anything else here? 🐰

@dbieber
Copy link
Member

dbieber commented Mar 7, 2023

Thanks for checking back in, but unfortunately no, no updates on my end.

@Borda
Copy link
Contributor Author

Borda commented Mar 24, 2023

Gentle ping @dbieber 🐿️

@Borda
Copy link
Contributor Author

Borda commented Sep 19, 2023

@dbieber how are you doing, still with this project? 🐿️

@Borda
Copy link
Contributor Author

Borda commented Jan 2, 2024

hello @dbieber, happy New year! 🎆

@Borda
Copy link
Contributor Author

Borda commented Jan 9, 2024

@dbieber any chance to get some more details on what is happening with the copybara?

@dbieber
Copy link
Member

dbieber commented Jan 9, 2024

@dbieber any chance to get some more details on what is happening with the copybara?

Hmm, I don't know offhand. Copybara is a tool we use to sync our internal and external codebases. I'll have to investigate.

@Borda
Copy link
Contributor Author

Borda commented Jan 9, 2024

I'll have to investigate.

lets try just restart it for now?

@dbieber
Copy link
Member

dbieber commented Jan 9, 2024

You can safely ignore it.

@Borda
Copy link
Contributor Author

Borda commented Jan 9, 2024

You can safely ignore it.

the rest is green 🟢

@Borda
Copy link
Contributor Author

Borda commented Feb 8, 2024

@dbieber, so can we merge it? 🤔

@dbieber
Copy link
Member

dbieber commented Feb 24, 2024

Hi Borda,

Thank you for the PR and your patience. I see the value of running the GitHub Actions on a pull_request. I do not see the value of the watcher job or auto-merge, however.

I understand that the watcher job would allow for auto-merge. Perhaps I am misunderstanding what auto-merge is, but it seems to me that I would like to review and approve PRs before they are merged, and hence I do not want to enable auto-merge on this project. Let me know if I'm misunderstanding auto-merge or missing something.

Cheers,
David

🐙

@Borda
Copy link
Contributor Author

Borda commented Feb 24, 2024

I understand that the watcher job would allow for auto-merge.

That is probably a misunderstanding; the watcher jobs just aggregated the result over the previously completed matrix of jobs... so the case is that in the GH setting you do not need to click all jobs one by one and if you change Python version it need to be also updated in the setting but you set as required only this one which is aggregated result of all

Borda and others added 3 commits March 11, 2024 21:16
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@Borda
Copy link
Contributor Author

Borda commented Apr 26, 2024

@dbieber, mind having a look and sharing your thoughts? 🦩
this will also be even more useful if we extend the testing matrix, ref #490

@Borda
Copy link
Contributor Author

Borda commented Jul 14, 2024

@dbieber friendly ping if you could have a look... 🐿️

.github/workflows/build.yml Outdated Show resolved Hide resolved
@Borda
Copy link
Contributor Author

Borda commented Sep 22, 2024

@dbieber after the extended build matrix this gain its value as so safety you can set this watcher as required check and so all builds are required but without the need to name them one by one...

@Borda
Copy link
Contributor Author

Borda commented Oct 7, 2024

@dbieber after the extended build matrix this gain its value as so safety you can set this watcher as required check and so all builds are required but without the need to name them one by one...

mind check this one, and also add this rather to required checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants