Google sync #724
Merged
Google sync #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the module name is "__builtin__", add {True, False, None, __debug__}
manually to the constant list after parsing the pyi file.
Also adds some minor fixes:
* convert NamedType("nothing") to NothingType()
* fix some noncompliant `def`s
PiperOrigin-RevId: 338530575
PiperOrigin-RevId: 338711741
PiperOrigin-RevId: 338742906
All of pytd/**/*.pytd is parsing now except for the shadowed module in attr/__init__.pytd PiperOrigin-RevId: 338747733
PiperOrigin-RevId: 339143448
PiperOrigin-RevId: 339551003
PiperOrigin-RevId: 339721735
Reachability metrics was originally recorded as CacheMetrics. However, the reachability mechanism is not actually a cache, but a dynamically-grown adjacency matrix. The idea of cache hits and misses is not relevant here. PiperOrigin-RevId: 339931062
We need to be able to round-trip pyi files with the new parser. PiperOrigin-RevId: 340283188
… place. We ultimately want to replace the `~` with a legal python character. PiperOrigin-RevId: 340286094
PiperOrigin-RevId: 340330922
The extra newline displeases oss pylint: https://travis-ci.org/github/google/pytype/jobs/741022897. PiperOrigin-RevId: 340360158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.