Fix pip install errors. #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting errors about cfg_logging.h being missing when trying to test a new release; this change seems to fix the issue. I'm still seeing some odd dynamic import failure, but python3.7 on my machine also appears to be half-broken right now, so I have no idea if the issue is with the pytype code or my environment.
For reasons mysterious to me, using Pybind11Extension leads to the error "ImportError: dynamic module does not define module export function (PyInit_parser_ext)", even if I set include_pybind11=False.
|
I fixed my Python 3.7 installation, and the pytype install was still broken, so I've pushed a commit to also fix the dynamic import failure. |
rchen152
changed the title
Solumin
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting errors about cfg_logging.h being missing when trying to
test a new release; this change seems to fix the issue.
I'm still seeing some odd dynamic import failure, but python3.7 on my
machine also appears to be half-broken right now, so I have no idea if
the issue is with the pytype code or my environment.