add windows support #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the os.Rename call with two separate implementations depending on target OS. On windows it uses the movefileex syscall to make the move atomic, unlike the implementation of os.Rename.
|
Fixes #1 |
stapelberg
reviewed
Nov 3, 2018
| func replaceFile(source, destination string) error { | ||
| src, err := syscall.UTF16PtrFromString(source) | ||
| if err != nil { | ||
| return &os.LinkError{"replace", source, destination, err} |
There was a problem hiding this comment.
here and below: could you please change the literal construction to use field names to be robust when os.LinkError changes? E.g. &os.LinkError{Op: "replace", Old: source, New: destination, Err: err}
There was a problem hiding this comment.
Let me know once you pushed the change :)
tklauser
reviewed
Mar 14, 2019
| } | ||
|
|
||
| // see http://msdn.microsoft.com/en-us/library/windows/desktop/aa365240(v=vs.85).aspx | ||
| if err := moveFileEx(src, dest, movefile_replace_existing|movefile_write_through); err != nil { |
There was a problem hiding this comment.
FWIW, golang.org/x/sys/windows has a wrapper for MoveFileExW, so it could be used instead of generating one here.
|
golang/go#32188 (comment) says MoveFileEx is not atomic under windows, and ReplaceFile should instead be used. |
|
golang/go#22397 (comment) says nothing is atomic under windows. Closing this until someone comes up with new evidence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the os.Rename call with two separate implementations depending
on target OS. On windows it uses the movefileex syscall to make the move
atomic, unlike the implementation of os.Rename.
Needs tests, for sure.