Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the payload digest #24

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Add the payload digest #24

merged 3 commits into from
Oct 4, 2019

Conversation

djgilcrease
Copy link
Contributor

Add the payload digest so that on fedora you do not need to install the rpm with the --nodigest flags

Before change

$ rpm -Kv test.rpm
test.rpm:
    Header SHA256 digest: OK
    Payload SHA256 digest: NOTFOUND
    MD5 digest: NOTFOUND

After Changes

$ rpm -Kv test.rpm
test.rpm:
    Header SHA256 digest: OK
    Payload SHA256 digest: OK

jarondl added a commit to jarondl/rpmpack that referenced this pull request Oct 3, 2019
@jarondl
Add a fedora image to the tests and see it fail without nodigest
25e3d47 
djgilcrease@ reported in google#24 that fedora installations currently fail
without passing in nodigest. That does seems to be true. I have
added a test case, that currently passes, but only because of the
`--nodigest` flag. Then as part of google#24 we can modify the testcase
to omit the flag.
@jarondl jarondl mentioned this pull request Oct 3, 2019
Merged
jarondl
jarondl requested changes Oct 3, 2019
View reviewed changes
Copy link
Collaborator

@jarondl jarondl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Looks good, except that I want to verify this solves this problem. Once #25 is in, I would like you to rebase to master, and then remove the nodigest flag from the fedora tests.

Thanks again.

Add the payload digest so that on fedora you do not need to install t…
018e203 
…he rpm with the `--nodigest` flags

Before change
```
$ rpm -Kv test.rpm
test.rpm:
    Header SHA256 digest: OK
    Payload SHA256 digest: NOTFOUND
    MD5 digest: NOTFOUND
```

After Changes
```
$ rpm -Kv test.rpm
test.rpm:
    Header SHA256 digest: OK
    Payload SHA256 digest: OK
```
@djgilcrease djgilcrease force-pushed the bugfix/digest-not-ok branch from 6d6da23 to 018e203 Compare October 3, 2019 21:22
@djgilcrease djgilcrease mentioned this pull request Oct 3, 2019
Merged
jarondl added 2 commits October 3, 2019 19:58
@jarondl
Merge branch 'master' into bugfix/digest-not-ok
f648fee
@jarondl
Remove --nodigest flag from fedora image.
bbcbbc8 
This should serve as a regression test with fedora and digests, see google#24
@jarondl jarondl merged commit 07246cf into google:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarondl jarondl jarondl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djgilcrease @jarondl