This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
async-caop-uri-macros: rewrote and updated them #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the
proc-macro
s to use the latest versions ofsyn
andquote
and improved the error messages by usingsyn::Error
andSpan
s.For example this error message is now returned
which previously was
In the future it would be possible to further improve the error messages to
but this requires
proc_macro::Literal::subspan
to be stable.I had to add
proc-macro2
as a dependency, becausesyn
only returnsproc-macro2
types and the conversion betweenproc-macro
andproc-macro2
is not always possible.For the new error messages I added
trybuild
, which allows to test thestderr
returned byproc-macro
s. I set up some basic tests for some of them, but not all of them.I also improved the verification of the
uri
encoding, by removing a lot of redundant code and simplifying the remaining code, which should have improved the parsing speed :)