Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

add send/sync bounds to prevent data race to RC of ArcGuard<Rc, T> #34

Merged
merged 2 commits into from
Jun 4, 2021
Merged

add send/sync bounds to prevent data race to RC of ArcGuard<Rc, T> #34

merged 2 commits into from
Jun 4, 2021

Conversation

JOE1994
Copy link
Contributor

@JOE1994 JOE1994 commented Jan 23, 2021

Fixes #33

This PR adds appropriate Send/Sync trait bounds to the Send/Sync impls of ArcGuard<RC, T>,
in order to prevent unsound programs at compile time.

Thank you for reviewing this PR 👍

@google-cla
Copy link

google-cla bot commented Jan 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@JOE1994
Copy link
Contributor Author

JOE1994 commented Jan 23, 2021

@googlebot I signed it!

@darconeous darconeous self-requested a review June 4, 2021 17:04
@darconeous
Copy link
Contributor

Not sure why travis is having trouble.

@darconeous darconeous merged commit 71245d4 into google:master Jun 4, 2021
@JOE1994
Copy link
Contributor Author

JOE1994 commented Jun 8, 2021

Thank you for merging the fix 👍 Would you also consider publishing a new minor release on crates.io?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArcGuard's Send and Sync should have bounds on RC
2 participants