Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bazel from s2a-go repo #103

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Remove bazel from s2a-go repo #103

merged 4 commits into from
Apr 19, 2023

Conversation

xmenxk
Copy link
Collaborator

@xmenxk xmenxk commented Apr 19, 2023

#99
#102

  1. deleted all existing bazel setup: BUILD files, WORKSPACE file
  2. removed bazel related kokoro tests
  3. moved .proto files into own folder, and regenerated the .pb.go files
  4. placed test key/cert pem files in the same package directory of the test.go file where they are embedded

Note: 3 and 4 are to make gazelle happy so that it generates proper BUILD.bazel files

  • it doesn't like multiple .proto files in the same folder
  • it can not find an embedded file if the file is outside of the package directory

Testing:

  • go test:
    go build ./...
    go test ./...

  • bazel test:
    // generate BUILD.bazel files with gazelle
    bazel run //:gazelle -- update-repos -prune -from_file=go.mod
    bazel run //:gazelle
    bazel build ...
    bazel test ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants