Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create Python wheels #313

Merged
merged 8 commits into from
Apr 28, 2023
Merged

Add ability to create Python wheels #313

merged 8 commits into from
Apr 28, 2023

Conversation

selimnairb
Copy link
Contributor

This pull request enables the creation of Python wheels via integration with CMake. This also changes the name of the Python library from pywraps2 to the more ergonomic s2geometry.

@google-cla
Copy link

google-cla bot commented Apr 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@jmr jmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is requested a lot and I never had time to look into it.

Note that we plan to delete the swig wrappers soon and use pybind11 or pyclif with a more Pythonic API.

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/python/CMakeLists.txt Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…ect source URL and license as well as add minimal classifiers; Edit README to be less repetitive re. handling OpenSSL location
setup.cfg Outdated
@@ -0,0 +1,22 @@
[metadata]
name = s2geometry
version = 0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the allowed format of version? Can this be 0.11.dev or prerelease or something?

0.10 has already been released, so it's probably not great if we end up with loads of variants built at different times claiming to be 0.10.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this to a PEP 440-compliant pre-release version number.

src/python/CMakeLists.txt Outdated Show resolved Hide resolved
@selimnairb
Copy link
Contributor Author

@jmr Let me know if there's anything more to be done on this PR and if there is anyway that I can help with the migration from SWIG. Thanks!

@jmr jmr merged commit 7773d51 into google:master Apr 28, 2023
@jmr
Copy link
Member

jmr commented Apr 28, 2023

Thanks! I'll let you know when we have something in the way of a SWIG replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants