Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modern cmake config targets to s2geometry #339

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Add modern cmake config targets to s2geometry #339

merged 5 commits into from
Jan 26, 2024

Commits on Jan 10, 2024

  1. Add modern cmake config targets to s2geometry

    @jherico
    jherico committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c9f9f26 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Config.cmake.in: Fix formatting

    @jmr
    jmr authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    36545ec View commit details
    Browse the repository at this point in the history

  2. CMakeLists.txt: Reformat 

    Fix formatting to be consistent with existing formatting.

Mostly, this is aligning after "(" if possible without a line wrap and moving ")" to be on a line with other content.  [")" handling does not seem to be consistent with the CMake docs, but is consistent with the rest of the file.]
    @jmr
    jmr authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    40da982 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @jherico
    jherico authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7860b23 View commit details
    Browse the repository at this point in the history

  4. CMakeLists.txt: Format comments

    @jmr
    jmr authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f599816 View commit details
    Browse the repository at this point in the history