santad: Synchronize access to metric callback array (#1405)

google · Jul 29, 2024 · 1ce4756 · 1ce4756
1 parent 9a7dcef
commit 1ce4756
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/Source/common/SNTMetricSet.m b/Source/common/SNTMetricSet.m
@@ -605,10 +605,15 @@ - (void)addConstantBooleanWithName:(NSString *)name
 
 /** Export current state of the SNTMetricSet as an NSDictionary. */
 - (NSDictionary *)export {
-  NSDictionary *exported = nil;
+  NSDictionary *exported;
+
+  NSArray *callbacks;
+  @synchronized(self) {
+    callbacks = [_callbacks mutableCopy];
+  }
 
   // Invoke callbacks to ensure metrics are up to date.
-  for (void (^cb)(void) in _callbacks) {
+  for (void (^cb)(void) in callbacks) {
     cb();
   }