Project: Re-enable layering_checks (#1350)

google · May 15, 2024 · 8e1e155 · 8e1e155
1 parent fb6aa85
commit 8e1e155
Show file tree

Hide file tree

Showing 18 changed files with 0 additions and 21 deletions.
diff --git a/BUILD b/BUILD
@@ -3,10 +3,6 @@ load("//:helper.bzl", "run_command")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    # NOTE: layering_check is disabled in all Santa BUILD files because the feature
-    # works inconsistently between versions of bazel in a way that causes problems
-    # when pulling the GitHub source into the internal source tree for building.
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Source/common/BUILD b/Source/common/BUILD
@@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Source/gui/BUILD b/Source/gui/BUILD
@@ -6,7 +6,6 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 exports_files([

diff --git a/Source/santabundleservice/BUILD b/Source/santabundleservice/BUILD
@@ -4,7 +4,6 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 objc_library(

diff --git a/Source/santactl/BUILD b/Source/santactl/BUILD
@@ -5,7 +5,6 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 objc_library(

diff --git a/Source/santad/BUILD b/Source/santad/BUILD
@@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD b/Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD
@@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 proto_library(

diff --git a/Source/santad/ProcessTree/BUILD b/Source/santad/ProcessTree/BUILD
@@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 cc_library(

diff --git a/Source/santad/ProcessTree/annotations/BUILD b/Source/santad/ProcessTree/annotations/BUILD
@@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 cc_library(

diff --git a/Source/santametricservice/BUILD b/Source/santametricservice/BUILD
@@ -3,7 +3,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Source/santametricservice/Formats/BUILD b/Source/santametricservice/Formats/BUILD
@@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Source/santametricservice/Writers/BUILD b/Source/santametricservice/Writers/BUILD
@@ -2,7 +2,6 @@ load("//:helper.bzl", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Source/santasyncservice/BUILD b/Source/santasyncservice/BUILD
@@ -5,7 +5,6 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 objc_library(

diff --git a/Testing/integration/BUILD b/Testing/integration/BUILD
@@ -2,7 +2,6 @@ load("//:helper.bzl", "run_command", "santa_unit_test")
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])

diff --git a/Testing/integration/VM/Common/BUILD b/Testing/integration/VM/Common/BUILD
@@ -2,7 +2,6 @@ package(
     default_visibility = [
         "//Testing/integration/VM:__subpackages__",
     ],
-    features = ["-layering_check"],
 )
 
 objc_library(

diff --git a/external_patches/OCMock/BUILD b/external_patches/OCMock/BUILD
@@ -2,5 +2,4 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
diff --git a/external_patches/moroz/BUILD b/external_patches/moroz/BUILD
@@ -2,5 +2,4 @@ licenses(["notice"])
 
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
diff --git a/profiles/BUILD b/profiles/BUILD
@@ -1,6 +1,5 @@
 package(
     default_visibility = ["//:santa_package_group"],
-    features = ["-layering_check"],
 )
 
 licenses(["notice"])