Fix check for deprecated clean sync key (#1397)

google · Jul 18, 2024 · f4ec2d5 · f4ec2d5
1 parent d54ec98
commit f4ec2d5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Source/santasyncservice/SNTSyncPreflight.mm b/Source/santasyncservice/SNTSyncPreflight.mm
@@ -250,7 +250,7 @@ - (BOOL)sync {
       case ::pbv1::NORMAL:                 // Intentional fallthrough
       default: self.syncState.syncType = SNTSyncTypeNormal; break;
     }
-  } else if (resp.has_deprecated_clean_sync()) {
+  } else if (resp.deprecated_clean_sync()) {
     // If the deprecated key is set, the type of sync clean performed should be
     // the type that was requested. This must be set appropriately so that it
     // can be propagated during the Rule Download stage so SNTRuleTable knows

diff --git a/Source/santasyncservice/SNTSyncTest.mm b/Source/santasyncservice/SNTSyncTest.mm
@@ -579,6 +579,13 @@ - (void)testPreflightStateCleanAllRequestCleanResponseCleanDep {
                                   response:@{kCleanSyncDeprecated : @YES}];
 }
 
+- (void)testPreflightStateNormalRequestNormalResponseCleanDep {
+  [self cleanSyncPreflightRequiredSyncType:SNTSyncTypeNormal
+                    expectcleanSyncRequest:NO
+                          expectedSyncType:SNTSyncTypeNormal
+                                  response:@{kCleanSyncDeprecated : @NO}];
+}
+
 - (void)testPreflightStateCleanAllRequestCleanResponseUnknown {
   [self cleanSyncPreflightRequiredSyncType:SNTSyncTypeCleanAll
                     expectcleanSyncRequest:YES