Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic dialog functionality when access to a watch item is denied #1106

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Jun 1, 2023

Note: This is a work in progress. PR is being cut in the current state to help keep the review smaller. All policies are hard coded to be silent and nothing will be displayed for now. But, if the silent member of WatchItemPolicy were changed to false then a dialog would be displayed as expected.

@mlw mlw requested a review from a team as a code owner June 1, 2023 17:54
pmarkowsky
pmarkowsky previously approved these changes Jun 16, 2023
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I think this is ok to approve as we know there more PRs to follow and this leaves the features inert and keeps the size of the PR more manageable.

Source/gui/SNTFileAccessMessageWindowView.swift Outdated Show resolved Hide resolved
Source/gui/SNTFileAccessMessageWindowView.swift Outdated Show resolved Hide resolved
Source/gui/SNTNotificationManager.h Outdated Show resolved Hide resolved
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving.

@mlw mlw merged commit 1e92d10 into google:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants