Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kSyncEnableCleanSyncEventUpload to the _forcedConfigKeyTypes dict #1123

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Add kSyncEnableCleanSyncEventUpload to the _forcedConfigKeyTypes dict #1123

merged 3 commits into from
Jul 6, 2023

Conversation

pmarkowsky
Copy link
Contributor

Fixes #1101.

@pmarkowsky pmarkowsky added sync service Issues related to the sync service / protocol configurator labels Jul 6, 2023
@pmarkowsky pmarkowsky requested a review from a team as a code owner July 6, 2023 21:03
@pmarkowsky pmarkowsky mentioned this pull request Jul 6, 2023
Closed
@pmarkowsky @russellhancox
Update Source/common/SNTConfigurator.m
b3157ce 
Co-authored-by: Russell Hancox <russellhancox@users.noreply.github.com>
@pmarkowsky pmarkowsky added this to the 2023.7 Release milestone Jul 6, 2023
@pmarkowsky pmarkowsky merged commit 9e124f4 into google:main Jul 6, 2023
9 checks passed
@pmarkowsky pmarkowsky deleted the markowsky/fix-snt-configurator branch July 6, 2023 21:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellhancox russellhancox russellhancox approved these changes

@mlw mlw mlw approved these changes

Assignees
No one assigned
Labels
configurator sync service Issues related to the sync service / protocol
Projects
None yet
Milestone
2023.6 Release
Development

Successfully merging this pull request may close these issues.

After turning on the clean_sync switch, the event logs are no longer being uploaded
3 participants
@pmarkowsky @russellhancox @mlw