Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce expected case for various rule type identifiers #1132

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Enforce expected case for various rule type identifiers #1132

merged 5 commits into from
Jul 26, 2023

Conversation

mlw
Copy link
Member

@mlw mlw commented Jul 26, 2023

This PR enforces the following:

  1. Binary and Certificate rule identifiers (sha 256 hex strings) will be converted to lowercase
  2. TeamID rule identifiers (10 character alphanumeric strings) will be converted to uppercase
  3. SigningID rule identifiers will have the TeamID portion of the rule be converted to uppercase, but the Signing ID portion will be left alone (e.g. tid:Sid --> TID:Sid)
    • However, if the hard coded TeamID "platform" is used, it will not have its case converted

fixes #1131

@mlw mlw added santad Work related to the Santa Daemon testing labels Jul 26, 2023
@mlw mlw requested a review from a team as a code owner July 26, 2023 04:33
@mlw mlw added this to the 2023.7 Release milestone Jul 26, 2023
pmarkowsky
pmarkowsky previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

russellhancox
russellhancox requested changes Jul 26, 2023
View reviewed changes
Source/common/SNTRule.m Outdated Show resolved Hide resolved
Source/common/SNTRule.m Show resolved Hide resolved
Source/common/SNTRule.m Outdated Show resolved Hide resolved
@mlw mlw requested a review from russellhancox July 26, 2023 16:08
@mlw mlw merged commit 6ed5bcd into google:main Jul 26, 2023
9 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellhancox russellhancox russellhancox approved these changes

@pmarkowsky pmarkowsky pmarkowsky left review comments

Assignees
No one assigned
Labels
santad Work related to the Santa Daemon testing
Projects
None yet
Milestone
2023.7 Release
Development

Successfully merging this pull request may close these issues.

Certificate SHA256 hashes are case-sensitive
3 participants
@mlw @russellhancox @pmarkowsky