Make FileChangesRegex apply to all file change event types #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
force-pushed
the
filechangesregex-more-events
branch
from
5454a8c
to
c27bf55
Compare
kallsyms
reviewed
Feb 20, 2024
kallsyms
approved these changes
Feb 20, 2024
mlw
force-pushed
the
filechangesregex-more-events
branch
from
59c9a97
to
108688a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Santa to apply the
FileChangesRegexconfig key to more event types, not justWRITE, as it used to do prior 2022.9. Specifically, this key now applies toUNLINK,RENAME,LINK, andEXCHANGEDATA.Additionally, the
FileChangesPrefixFiltersconfig item now also applies toEXCHANGEDATA(as well as the previously mentioned event types that were already applied).b/325550489