Update SNTPolicyProcessor to use a map #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmarkowsky
force-pushed
the
markowsky/refactor-policy-processor
branch
from
d73d15f
to
d642bde
Compare
russellhancox
requested changes
Mar 14, 2024
russellhancox
approved these changes
Mar 14, 2024
pmarkowsky
force-pushed
the
markowsky/refactor-policy-processor
branch
2 times, most recently
from
f747b57
to
95c1351
Compare
pmarkowsky
force-pushed
the
markowsky/refactor-policy-processor
branch
from
95c1351
to
3e19d5c
Compare
russellhancox
previously approved these changes
Apr 1, 2024
mlw
requested changes
Apr 5, 2024
…ement Update SNTPolicyProcessor to use a map instead of a giant switch statement. Add unit tests for the method that sets SNTCachedDecision values.
pmarkowsky
force-pushed
the
markowsky/refactor-policy-processor
branch
from
8e8e9ae
to
9efe329
Compare
mlw
requested changes
May 8, 2024
mlw
previously approved these changes
May 9, 2024
russellhancox
requested changes
May 9, 2024
Co-authored-by: Russell Hancox <russellhancox@users.noreply.github.com>
Co-authored-by: Russell Hancox <russellhancox@users.noreply.github.com>
russellhancox
previously approved these changes
May 9, 2024
russellhancox
approved these changes
May 9, 2024
mlw
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors SNTPolicyProcessor to use a flat_hash_map instead of the switch statement.
This is being done for two reasons: