Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Migrate to bazel modules #1324

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

russellhancox
Copy link
Collaborator

No description provided.

@russellhancox russellhancox requested a review from a team as a code owner April 8, 2024 20:51
WORKSPACE Show resolved Hide resolved
@mlw mlw added this to the 2024.5 milestone Apr 9, 2024
@mlw mlw added the build label Apr 9, 2024
@russellhancox russellhancox enabled auto-merge (squash) April 9, 2024 16:35
Passing test data via the data parameter no longer works, using structured_resources and accessing via the NSBundle still works well.
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@russellhancox russellhancox merged commit 344a35a into google:main Apr 11, 2024
11 checks passed
@russellhancox russellhancox deleted the bazel-modules branch April 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants