Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: Disable layering_check in all BUILD files #1344

Merged
merged 1 commit into from
May 9, 2024
Merged

Project: Disable layering_check in all BUILD files #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
load("@build_bazel_rules_apple//apple:versioning.bzl", "apple_bundle_version")
load("//:helper.bzl", "run_command")

package(default_visibility = ["//:santa_package_group"])
package(
default_visibility = ["//:santa_package_group"],
# NOTE: layering_check is disabled in all Santa BUILD files because the feature
# works inconsistently between versions of bazel in a way that causes problems
# when pulling the GitHub source into the internal source tree for building.
features = ["-layering_check"],
)

licenses(["notice"])

Expand Down
1 change: 1 addition & 0 deletions Source/common/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 1 addition & 0 deletions Source/gui/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

exports_files([
Expand Down
1 change: 1 addition & 0 deletions Source/santabundleservice/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 1 addition & 0 deletions Source/santactl/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 1 addition & 0 deletions Source/santad/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 1 addition & 0 deletions Source/santad/Logs/EndpointSecurity/Writers/FSSpool/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

proto_library(
Expand Down
11 changes: 5 additions & 6 deletions Source/santad/ProcessTree/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
load("@rules_cc//cc:defs.bzl", "cc_proto_library")
load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

cc_library(
name = "process",
hdrs = ["process.h"],
visibility = ["//:santa_package_group"],
deps = [
"//Source/santad/ProcessTree/annotations:annotator",
"@com_google_absl//absl/container:flat_hash_map",
Expand All @@ -26,7 +30,6 @@ objc_library(
sdk_dylibs = [
"bsm",
],
visibility = ["//:santa_package_group"],
deps = [
":process",
"//Source/santad/ProcessTree:process_tree_cc_proto",
Expand All @@ -42,12 +45,10 @@ objc_library(
proto_library(
name = "process_tree_proto",
srcs = ["process_tree.proto"],
visibility = ["//:santa_package_group"],
)

cc_proto_library(
name = "process_tree_cc_proto",
visibility = ["//:santa_package_group"],
deps = [":process_tree_proto"],
)

Expand All @@ -58,7 +59,6 @@ objc_library(
sdk_dylibs = [
"bsm",
],
visibility = ["//:santa_package_group"],
deps = [
":process_tree",
"//Source/santad:EndpointSecurityAPI",
Expand All @@ -71,7 +71,6 @@ objc_library(
name = "process_tree_test_helpers",
srcs = ["process_tree_test_helpers.mm"],
hdrs = ["process_tree_test_helpers.h"],
visibility = ["//Source/santad/ProcessTree:__subpackages__"],
deps = [
":process",
":process_tree",
Expand Down
1 change: 1 addition & 0 deletions Source/santad/ProcessTree/annotations/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

cc_library(
Expand Down
1 change: 1 addition & 0 deletions Source/santametricservice/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 1 addition & 0 deletions Source/santametricservice/Formats/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 1 addition & 0 deletions Source/santametricservice/Writers/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ load("//:helper.bzl", "santa_unit_test")

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
1 change: 1 addition & 0 deletions Source/santasyncservice/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

objc_library(
Expand Down
5 changes: 4 additions & 1 deletion Testing/integration/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
load("//:helper.bzl", "run_command", "santa_unit_test")

package(default_visibility = ["//:santa_package_group"])
package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])

Expand Down
1 change: 1 addition & 0 deletions Testing/integration/VM/Common/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package(
default_visibility = [
"//Testing/integration/VM:__subpackages__",
],
features = ["-layering_check"],
)

objc_library(
Expand Down
1 change: 1 addition & 0 deletions external_patches/OCMock/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)
1 change: 1 addition & 0 deletions external_patches/moroz/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ licenses(["notice"])

package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)
1 change: 1 addition & 0 deletions profiles/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package(
default_visibility = ["//:santa_package_group"],
features = ["-layering_check"],
)

licenses(["notice"])
Expand Down
Loading