Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: Add a protobuf for the existing sync protocol #1359

Merged
merged 12 commits into from
May 29, 2024

Commits on May 28, 2024

  1. sync: Add a protobuf for the existing sync protocol

    This PR is intended to have no impact on existing sync servers. The fields and enum values in the protobuf have been named such that their JSON equivalents match the existing constants we have in the codebase.
    
    Adding this provides a few benefits:
    
    1. The protobuf serves as canonical documentation of the protocol in a form that's much easier to read than the existing code.
    2. Protobuf parsing of JSON is likely to be better than our hand-written version.
    3. We can (in a later PR) add a configuration option to use binary encoding instead of JSON, saving network during syncs.
    4. Servers written in other languages are easier to write and update as time goes on, especially as we extend the protocol.
    russellhancox committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5fcf274 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    14a07ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    61e3e63 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5c369fa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ebe837e View commit details
    Browse the repository at this point in the history
  6. Remove JSON debug log

    russellhancox committed May 28, 2024
    Configuration menu
    Copy the full SHA
    21e9a04 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    006fbf6 View commit details
    Browse the repository at this point in the history
  8. Fix lint again

    russellhancox committed May 28, 2024
    Configuration menu
    Copy the full SHA
    a41b033 View commit details
    Browse the repository at this point in the history
  9. Add comments to many fields.

    Also fix push notification global rule interval setting
    russellhancox committed May 28, 2024
    Configuration menu
    Copy the full SHA
    66ad2d6 View commit details
    Browse the repository at this point in the history
  10. Fix lint, again...

    russellhancox committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0c57d50 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    909e8fd View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Configuration menu
    Copy the full SHA
    b390296 View commit details
    Browse the repository at this point in the history