-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: Add a protobuf for the existing sync protocol #1359
Merged
Merged
Commits on May 28, 2024
-
sync: Add a protobuf for the existing sync protocol
This PR is intended to have no impact on existing sync servers. The fields and enum values in the protobuf have been named such that their JSON equivalents match the existing constants we have in the codebase. Adding this provides a few benefits: 1. The protobuf serves as canonical documentation of the protocol in a form that's much easier to read than the existing code. 2. Protobuf parsing of JSON is likely to be better than our hand-written version. 3. We can (in a later PR) add a configuration option to use binary encoding instead of JSON, saving network during syncs. 4. Servers written in other languages are easier to write and update as time goes on, especially as we extend the protocol.
Configuration menu - View commit details
-
Copy full SHA for 5fcf274 - Browse repository at this point
Copy the full SHA 5fcf274View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14a07ce - Browse repository at this point
Copy the full SHA 14a07ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61e3e63 - Browse repository at this point
Copy the full SHA 61e3e63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c369fa - Browse repository at this point
Copy the full SHA 5c369faView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebe837e - Browse repository at this point
Copy the full SHA ebe837eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e9a04 - Browse repository at this point
Copy the full SHA 21e9a04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 006fbf6 - Browse repository at this point
Copy the full SHA 006fbf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a41b033 - Browse repository at this point
Copy the full SHA a41b033View commit details -
Also fix push notification global rule interval setting
Configuration menu - View commit details
-
Copy full SHA for 66ad2d6 - Browse repository at this point
Copy the full SHA 66ad2d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c57d50 - Browse repository at this point
Copy the full SHA 0c57d50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 909e8fd - Browse repository at this point
Copy the full SHA 909e8fdView commit details
Commits on May 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b390296 - Browse repository at this point
Copy the full SHA b390296View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.