Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

santad: Synchronize access to metric callback array #1405

Merged
merged 2 commits into from
Jul 29, 2024
Merged

santad: Synchronize access to metric callback array #1405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5e89e7
santad: Synchronize access to metric callback array
russellhancox Jul 25, 2024
412c9d6
Merge branch 'main' into metric-locks
russellhancox Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Source/common/SNTMetricSet.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,10 +605,15 @@ - (void)addConstantBooleanWithName:(NSString *)name

/** Export current state of the SNTMetricSet as an NSDictionary. */
- (NSDictionary *)export {
NSDictionary *exported = nil;
NSDictionary *exported;

NSArray *callbacks;
@synchronized(self) {
callbacks = [_callbacks mutableCopy];
}

// Invoke callbacks to ensure metrics are up to date.
for (void (^cb)(void) in _callbacks) {
for (void (^cb)(void) in callbacks) {
cb();
}
russellhancox marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
Loading