Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attack point iterator constants #189

Merged
merged 17 commits into from
Jan 25, 2024
Merged

Add attack point iterator constants #189

merged 17 commits into from
Jan 25, 2024

Conversation

LucaTomasko
Copy link
Contributor

No description provided.

@kralka kralka self-requested a review January 19, 2024 11:37
kralka
kralka reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@kralka kralka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, please take a look at the failed workflows. If you need help let me know

scaaml/capture/input_generators/attack_point_itarator.py Outdated Show resolved Hide resolved
kralka
kralka reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@kralka kralka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a couple nits

scaaml/capture/input_generators/attack_point_iterator.py Outdated Show resolved Hide resolved
scaaml/capture/input_generators/attack_point_iterator.py Show resolved Hide resolved
scaaml/capture/input_generators/attack_point_iterator.py Outdated Show resolved Hide resolved
scaaml/capture/input_generators/attack_point_iterator.py Show resolved Hide resolved
kralka
kralka reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@kralka kralka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM from me. Letting some time for JM to comment (and adding two nits which I should have pointed earlier).

tests/capture/input_generators/test_attack_point_iterator.py Show resolved Hide resolved
scaaml/capture/input_generators/attack_point_iterator.py Show resolved Hide resolved
@kralka kralka requested a review from jmichelp January 24, 2024 17:43
jmichelp
jmichelp reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@jmichelp jmichelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but letting Karel approve.

tests/capture/input_generators/test_attack_point_iterator.py Outdated Show resolved Hide resolved
kralka
kralka approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@kralka kralka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kralka kralka merged commit 6ee2dcb into google:main Jan 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmichelp jmichelp jmichelp left review comments

@kralka kralka kralka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucaTomasko @kralka @jmichelp