Modernize custom metrics #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add get_config and from_config methods to custom metrics so that their serialization is automatic and test this. Preventing future occurance of issue mitigated in google#299. - Modernize from TensorFlow only to Keras with multi-backend. By using keras.ops in place of tf functions. - Remove the parameter `decimals` from MaxRank since it was unused and the original use was showing the metric as an integer (ignored by the training output).
Pull Request Test Coverage Report for Build 11106539752Details
💛 - Coveralls |
invernizzi
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get_config and from_config methods to custom metrics so that their serialization is automatic and test this. Preventing future occurance of issue mitigated in Add forgotten custom object for MeanRank #299.
Modernize from TensorFlow only to Keras with multi-backend. By using keras.ops in place of tf functions.
Remove the parameter
decimalsfrom MaxRank since it was unused and the original use was showing the metric as an integer (ignored by the training output).TODO(low priority): Move from SciPy to allow using SignificanceTest during training.