Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the maximum number of arguments #27

Merged
merged 1 commit into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -440,3 +440,6 @@ valid-metaclass-classmethod-first-arg=mcs
overgeneral-exceptions=builtins.StandardError,
builtins.Exception,
builtins.BaseException

# Set number of arguments for too-many-arguments
max-args = 10
8 changes: 4 additions & 4 deletions src/sedpack/io/dataset_iteration.py
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def as_tfdataset( # pylint: disable=too-many-arguments

return tf_dataset

async def as_numpy_iterator_async( # pylint: disable=too-many-arguments
async def as_numpy_iterator_async(
self,
*,
split: SplitT,
Expand Down Expand Up @@ -352,7 +352,7 @@ async def as_numpy_iterator_async( # pylint: disable=too-many-arguments
async for example in example_iterator:
yield example

def _as_numpy_common( # pylint: disable=too-many-arguments
def _as_numpy_common(
self,
*,
split: SplitT,
Expand Down Expand Up @@ -403,7 +403,7 @@ def _as_numpy_common( # pylint: disable=too-many-arguments
buffer_size=len(shard_paths))
return shard_paths_iterator

def as_numpy_iterator_concurrent( # pylint: disable=too-many-arguments
def as_numpy_iterator_concurrent(
self,
*,
split: SplitT,
Expand Down Expand Up @@ -506,7 +506,7 @@ def as_numpy_iterator_concurrent( # pylint: disable=too-many-arguments
itertools.islice(shard_paths_iterator,
file_parallelism))

def as_numpy_iterator( # pylint: disable=too-many-arguments
def as_numpy_iterator(
self,
*,
split: SplitT,
Expand Down