Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial iOS support #83

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Initial iOS support #83

merged 2 commits into from
Sep 24, 2020

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Sep 20, 2020

Pretty consistently, people open up the generated CMakeCache.txt and change CMAKE_OSX_SYSROOT to point to the iOS SDK path. This PR makes it so they don't have to do it manually. I've also gone ahead and added the iphonesimulator and the phone target to travis so there's a small amount of CI. I'm open to adding cargo-dinghy to effectively run cargo test for the iOS simulator if we'd like. I just wanted to keep the PR small.

Let me know if there's any changes you'd like.

@google-cla
Copy link

google-cla bot commented Sep 20, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Sep 20, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@antiagainst antiagainst merged commit 117e4fa into google:master Sep 24, 2020
@simlay
Copy link
Contributor Author

simlay commented Oct 5, 2020

Did this break the build? I'm looking at the current build and it's failed but there's not a clear reason why.

@antiagainst
Copy link
Collaborator

Yeah I think there were some issues with the configuration. I've #85, which hopefully can fix the issue.

@antiagainst antiagainst mentioned this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants