Bug/10040 input copy #10183
Open
Bug/10040 input copy #10183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 4a26f0b are ready:
|
|
Size Change: -183 B (-0.01%) Total Size: 2 MB
ℹ️ View Unchanged
|
aaemnnosttv
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Thanks @zutigrm – just a few points to address, otherwise this is almost good to go.
| @@ -54,6 +54,10 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
|
|
|||
| @media (min-width: $bp-wpdb3) { | |||
There was a problem hiding this comment.
This variable is for a breakpoint which is defined as specific to the WP dashboard, so we shouldn't be using it on other screens.
| 'google-site-kit' | ||
| ), | ||
| description: __( | ||
| 'Based on your answers, Site Kit will tailor the metrics and recommendations you see on your dashboard to help you make progress in these areas', | ||
| 'Based on your answer, Site Kit will suggest the metrics you see on your dashboard to help you track how close you’re getting to your specific goals', |
There was a problem hiding this comment.
Are we sure these are all supposed to have the same description? I see it is this way in the design but it's worth double checking to make sure that is correct. If so, we can extract it to a variable that's translated once to make that a bit more explicit as well.
There was a problem hiding this comment.
Thanks. Sure, will double check with Sigal. So far all the changes in Figma for ACR were intended and considered latest, or source of truth. Will let you know once Sigal gets back to me on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist