-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom retry map for exponential retries. #2769
Conversation
@@ -17,7 +17,7 @@ | |||
"php": ">=5.6", | |||
"ext-json": "*", | |||
"ext-openssl": "*", | |||
"google/apiclient": "^2.0", | |||
"google/apiclient": "^2.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benbowler changing the version manually in the composer.json file is not enough because in this case the composer.lock file remains the same. We need to update the dependency version correctly which will mean that the lock file should be updated as well.
Just run composer remove google/apiclient
to remove the existing version and run composer require google/apiclient
to install the latest one. It will correctly update composer.json and composer.lock files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I failed to commit the composer.lock
. Pushed up now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Summary
Addresses issue #2688
Relevant technical choices
Checklist