Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom retry map for exponential retries. #2769

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Feb 8, 2021

Summary

Addresses issue #2688

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Feb 8, 2021
@@ -17,7 +17,7 @@
"php": ">=5.6",
"ext-json": "*",
"ext-openssl": "*",
"google/apiclient": "^2.0",
"google/apiclient": "^2.9.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbowler changing the version manually in the composer.json file is not enough because in this case the composer.lock file remains the same. We need to update the dependency version correctly which will mean that the lock file should be updated as well.

Just run composer remove google/apiclient to remove the existing version and run composer require google/apiclient to install the latest one. It will correctly update composer.json and composer.lock files.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I failed to commit the composer.lock. Pushed up now.

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit fb2bbdf into develop Feb 12, 2021
@felixarntz felixarntz deleted the enhancement/2688-remove-custom-retry-map branch February 12, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants