Fix crash rendering emoji on macOS with FontCollection that lacks def… #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault font manager FontCollection checks if fDefaultFontManager is non-null in various places before using it, except when determining the emoji fallback font. This can cause a crash when the FontCollection was not initialized with a default font manager. This is reproducible for me on macOS with the 🍃 emoji.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tronical
force-pushed
the
simon/fix-emoji-crash
branch
from
8b310f9 to
e59f016
Compare
|
This PR (HEAD: e59f016) has been imported to Gerrit for code review. Please visit review.skia.org/819916 to see it. Please CC yourself to the Gerrit change. Note:
|
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Feb 28, 2024
Set a default font manager to avoid that the unconditional dereferencing inside Skia crashes on a null pointer. Upstream PR: google/skia#162 Fixes #4696
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Feb 28, 2024
Set a default font manager to avoid that the unconditional dereferencing inside Skia crashes on a null pointer. Upstream PR: google/skia#162 Fixes #4696
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Feb 29, 2024
Set a default font manager to avoid that the unconditional dereferencing inside Skia crashes on a null pointer. Upstream PR: google/skia#162 Fixes #4696
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Jun 3, 2024
While google/skia#162 has not been merged yet, it's included in skia-safe: rust-skia/rust-skia#986
tronical
added a commit
to slint-ui/slint
that referenced
this pull request
Jun 3, 2024
While google/skia#162 has not been merged yet, it's included in skia-safe: rust-skia/rust-skia#986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ault font manager
FontCollection checks if fDefaultFontManager is non-null in various places before using it, except when determining the emoji fallback font. This can cause a crash when the FontCollection was not initialized with a default font manager.
This is reproducible for me on macOS with the 🍃 emoji.