Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Commit

Permalink
Merge pull request #170 from google/pavel-feedback
Browse files Browse the repository at this point in the history
Address feedback from a tester
  • Loading branch information
bpytlik authored May 23, 2022
2 parents f6ecb7f + 32aa1f1 commit 5451138
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 8 deletions.
7 changes: 5 additions & 2 deletions walkthroughs/week-0-setup/github-setup-walkthrough.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,11 @@ to do this.
## Modify README

To test that everything is connected, modify your
<walkthrough-editor-open-file filePath="software-product-sprint/README.md">README.md</walkthrough-editor-open-file>
file.
<walkthrough-editor-spotlight spotlightId="navigator" spotlightItem="README.md">README.md</walkthrough-editor-spotlight>
file by double clicking on it. If you can't see line numbers to the left of the text, you're seeing the preview tab rather
than the editing tab. If there's a second tab available, try clicking it. If only a single tab is visible, try double
clicking the <walkthrough-editor-spotlight spotlightId="navigator" spotlightItem="README.md">README.md</walkthrough-editor-spotlight> file again.


This file contains the content that shows in your repo's GitHub page.
Change it to say "This repo contains [your name]'s portfolio and
Expand Down
9 changes: 5 additions & 4 deletions walkthroughs/week-0-setup/intro-walkthrough.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,12 @@ directories and view and edit files.
The editor displays the directory structure in its left-hand panel. You'll learn
more about these files throughout SPS, but for now try clicking around to
explore. Try opening the
<walkthrough-editor-open-file
filePath="software-product-sprint/walkthroughs/week-0-setup/intro-walkthrough.md">
<walkthrough-editor-spotlight spotlightId="navigator" spotlightItem="intro-walkthrough.md">
intro-walkthrough.md
</walkthrough-editor-open-file>
file to view the source for this walkthrough!
</walkthrough-editor-spotlight>
file by double clicking it to view the source for this walkthrough! It'll open two tabs,
the tab with the line numbers along the left-hand side is the source, the other is a preview
view of the same content.

You'll be using the Cloud Shell editor quite a bit in the coming weeks, so take
some time to familiarize yourself now. You can read more about Cloud Shell
Expand Down
8 changes: 6 additions & 2 deletions walkthroughs/week-1-web-development/portfolio-walkthrough.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ First, make these changes to your code. (You only need to do this once.)
- Open the
<walkthrough-editor-open-file
filePath="software-product-sprint/portfolio/pom.xml">
pom.xml
software-product-sprint/portfolio/pom.xml
</walkthrough-editor-open-file>
file.
- Change `YOUR_PROJECT_ID_HERE` to your project ID.
Expand Down Expand Up @@ -156,7 +156,8 @@ to include your name.

## Example

The `examples/stanley` directory contains an example webpage. It contains
The `examples/stanley` directory (inside the `software-product-sprint/walkthrough/week-1-web-development` directory)
contains an example webpage. It contains
several files and directories:

- <walkthrough-editor-open-file
Expand Down Expand Up @@ -364,6 +365,9 @@ To commit changes, run:
git commit -m "YOUR COMMIT MESSAGE"
```

You'll be using git to manage all your work during SPS. You can learn more about
how we'll use git in SPS [here](https://sites.google.com/sps-program.com/students/technical-resources/using-git).

## Pull Requests

Your advisor will be reviewing your code to provide feedback and support. If
Expand Down
10 changes: 10 additions & 0 deletions walkthroughs/week-3-libraries/datastore/datastore-walkthrough.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,11 @@ Modify your servlet file to take the data entered by users in your "contact me"
form and store it as an entity in Datastore. Get this working before
you worry about loading the data.

The first time you deploy your application, you may encounter an error like this when
submitting the form:
`com.google.cloud.datastore.DatastoreException: Cloud Datastore API has not been used ...`.
If you do, follow the link in the error message and enable the Cloud Datastore API.

### Admin Page

Datastore includes an admin page that gives you access to its data. This is very
Expand Down Expand Up @@ -226,6 +231,11 @@ page.

You should also consider hiding personal data like email addresses.

If you use of jSoup, you'll need to added it as a dependency in your
<walkthrough-editor-open-file filePath="software-product-sprint/portfolio/pom.xml">pom.xml
</walkthrough-editor-open-file> file. You can find an example
<walkthrough-editor-open-file filePath="software-product-sprint/walkthroughs/week-3-libraries/datastore/examples/todo-list/pom.xml">here</walkthrough-editor-open-file>.

## Pull Requests

<walkthrough-conclusion-trophy></walkthrough-conclusion-trophy>
Expand Down

0 comments on commit 5451138

Please sign in to comment.